Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentations for the release process of Helm charts #723

Merged
merged 4 commits into from
Nov 15, 2022

Conversation

kevin85421
Copy link
Member

@kevin85421 kevin85421 commented Nov 15, 2022

Why are these changes needed?

We need to formalize the release process. Documents are helpful.

Related issue number

Closes #724

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

@kevin85421 kevin85421 marked this pull request as ready for review November 15, 2022 00:50
docs/release/helm-chart.md Outdated Show resolved Hide resolved
helm install ray-cluster kuberay/ray-cluster
```

## Delete the existing releases
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need to delete existing releases?

Should we maintain Helm release version for each KubeRay release?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need to delete existing releases?

Because the chart-releaser will only be triggered when the PR is merged into main, maintainers may want to revert some wrong PRs. For example, a release manager of 0.4.0 forgets to update version from 0.3.0 to 0.4.0 in Chart.yaml, so the existing 0.3.0 releases and index.yaml update. In this case, we need to follow the "Delete the existing releases" section to revert.

Should we maintain Helm release version for each KubeRay release?

Yes

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, makes sense -- could you clarify that deleting charts is only for such situations?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I think it already sufficiently conveys that deleting things is not recommended.

Co-authored-by: Dmitri Gekhtman <[email protected]>
Signed-off-by: Kai-Hsun Chen <[email protected]>
kevin85421 and others added 2 commits November 14, 2022 20:04
Co-authored-by: Dmitri Gekhtman <[email protected]>
Signed-off-by: Kai-Hsun Chen <[email protected]>
Co-authored-by: Dmitri Gekhtman <[email protected]>
Signed-off-by: Kai-Hsun Chen <[email protected]>
@DmitriGekhtman DmitriGekhtman merged commit 0bd28e7 into ray-project:master Nov 15, 2022
lowang-bh pushed a commit to lowang-bh/kuberay that referenced this pull request Sep 24, 2023
…t#723)

Formalize and document the Helm release process.

Co-authored-by: Dmitri Gekhtman <[email protected]>
Signed-off-by: Kai-Hsun Chen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add documentations for the release process of Helm charts
2 participants